Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: Fix teams.listAll end-to-end tests #32586

Merged
merged 2 commits into from
Jun 11, 2024
Merged

regression: Fix teams.listAll end-to-end tests #32586

merged 2 commits into from
Jun 11, 2024

Conversation

matheusbsilva137
Copy link
Member

@matheusbsilva137 matheusbsilva137 commented Jun 11, 2024 •
edited
Loading

Proposed changes (including videos or screenshots)

  • Fixed teams.listAll end-to-end tests

Issue(s)

Steps to test or reproduce

Further comments

Introduced by #31756 and #32351

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 11, 2024 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: fa85496

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@matheusbsilva137 matheusbsilva137 changed the title regression: Fix teams.listAll end-to-end tests regression: Fix teams.listAll end-to-end tests Jun 11, 2024
@matheusbsilva137 matheusbsilva137 added this to the 7.0 milestone Jun 11, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.34%. Comparing base (903031c) to head (fa85496).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #32586   +/-   ##
==============================================
  Coverage          56.33%   56.34%           
==============================================
  Files               2437     2437           
  Lines              53821    53821           
  Branches           11101    11101           
==============================================
+ Hits               30320    30325    +5     
- Misses             20847    20850    +3     
+ Partials            2654     2646    -8
Flag Coverage Δ
e2e 56.03% <ø> (-0.03%) ⬇️
unit 71.90% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review June 11, 2024 17:46
@matheusbsilva137 matheusbsilva137 requested a review from a team as a code owner June 11, 2024 17:46
@ggazzo ggazzo merged commit ea82dad into release-7.0.0 Jun 11, 2024
48 checks passed
@ggazzo ggazzo deleted the regression/teams-list-all-end-to-end-tests branch June 11, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@matheusbsilva137 @ggazzo